From eebe772da67fd7af19d641aa8b53f7adb55d901e Mon Sep 17 00:00:00 2001 From: Palash Tyagi <23239946+Magnus167@users.noreply.github.com> Date: Sat, 12 Jul 2025 01:11:41 +0100 Subject: [PATCH] Add test for invalid activation count in DenseNNConfig to ensure proper configuration --- src/compute/models/dense_nn.rs | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/compute/models/dense_nn.rs b/src/compute/models/dense_nn.rs index b9f5a00..cdb2e32 100644 --- a/src/compute/models/dense_nn.rs +++ b/src/compute/models/dense_nn.rs @@ -242,6 +242,22 @@ mod tests { assert_eq!(preds.cols(), 1); } + #[test] + #[should_panic(expected = "Number of activation functions must match number of layers")] + fn test_invalid_activation_count() { + let config = DenseNNConfig { + input_size: 2, + hidden_layers: vec![3], + activations: vec![ActivationKind::Relu], // Only one activation for two layers + output_size: 1, + initializer: InitializerKind::Uniform(0.1), + loss: LossKind::MSE, + learning_rate: 0.01, + epochs: 0, + }; + let _model = DenseNN::new(config); + } + #[test] fn test_train_no_epochs_does_nothing() { let config = DenseNNConfig { @@ -496,7 +512,6 @@ mod tests { // Verify that weights and biases of both layers have changed, // implying delta propagation occurred for l > 0 - // Weights of first layer did not change, delta propagation might not have occurred assert!(model.weights[0] != initial_weights_l0); // Biases of first layer did not change, delta propagation might not have occurred