magnus167/rustframe
1
0
Fork 0
mirror of https://github.com/Magnus167/rustframe.git synced 2025-08-20 04:00:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix dimension mismatch assertion in zip method and add panic test for incompatible matrices

Browse Source
This commit is contained in:
Palash Tyagi 2025-07-06 10:54:23 +01:00
parent 601dc66d7d
commit 2da1e9bf04
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/matrix/seriesops.rs
View File

@ -189,18 +189,12 @@ impl SeriesOps for FloatMatrix {
where
F: Fn(f64, f64) -> f64,
{
assert_eq!(
assert!(
self.rows() == other.rows() && self.cols() == other.cols(),
"Matrix dimensions mismatch: left is {}x{}, right is {}x{}",
self.rows(),
self.cols(),
other.rows(),
"Row count mismatch: {} vs {}",
self.rows(),
other.rows()
);
assert_eq!(
self.cols(),
other.cols(),
"Column count mismatch: {} vs {}",
self.cols(),
other.cols()
);
@ -420,6 +414,15 @@ mod tests {
assert_eq!(zipped_matrix, expected_matrix);
}
#[test]
#[should_panic(expected = "Matrix dimensions mismatch: left is 2x2, right is 3x2")]
fn test_series_ops_zip_panic() {
let a = FloatMatrix::from_vec(vec![1.0, 2.0, 3.0, 4.0], 2, 2); // 2x2 matrix
let b = FloatMatrix::from_vec(vec![5.0, 6.0, 7.0, 8.0, 9.0, 10.0], 3, 2); // 3x2 matrix
// This should panic due to dimension mismatch
a.zip(&b, |x, y| x + y);
}
// --- Edge Cases for SeriesOps ---
#[test]