From d05618f10610caee0055df1c8b439d914aa5f965 Mon Sep 17 00:00:00 2001
From: Palash Tyagi <23239946+Magnus167@users.noreply.github.com>
Date: Wed, 13 Nov 2024 01:08:57 +0000
Subject: [PATCH] refactor: adjust batch size for ticker downloads and simplify
 main function logic

---
 src/download/jpmaqsdownload.rs | 3 +--
 src/main.rs                    | 6 ++----
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/download/jpmaqsdownload.rs b/src/download/jpmaqsdownload.rs
index 7a5364c..da43d2b 100644
--- a/src/download/jpmaqsdownload.rs
+++ b/src/download/jpmaqsdownload.rs
@@ -202,7 +202,6 @@ impl JPMaQSDownload {
     pub fn save_indicators_as_csv(
         &mut self,
         download_args: JPMaQSDownloadGetIndicatorArgs,
-        batch_size: usize,
         folder_path: &str,
     ) -> Result<(), Box<dyn Error>> {
         // if the folder path does not exist, create it
@@ -211,7 +210,7 @@ impl JPMaQSDownload {
         std::fs::create_dir_all(save_path.clone())?;
 
         // get ticker count, and split into chunks of batch_size
-        let ticker_batches = download_args.tickers.chunks(batch_size);
+        let ticker_batches = download_args.tickers.chunks(500);
         let batch_download_args = ticker_batches
             .map(|ticker_batch| {
                 let mut new_args = download_args.clone();
diff --git a/src/main.rs b/src/main.rs
index b01a565..871f6cd 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -1,5 +1,4 @@
 use msyrs::download::jpmaqsdownload::{JPMaQSDownload, JPMaQSDownloadGetIndicatorArgs};
-use polars::prelude::*;
 
 fn main() {
     println!("Authentication to DataQuery API");
@@ -17,7 +16,7 @@ fn main() {
         start.elapsed()
     );
 
-    let num_ticks = tickers.len();
+    let num_ticks = 100;
     let sel_tickers: Vec<String> = tickers
         .iter()
         .take(num_ticks)
@@ -27,13 +26,12 @@ fn main() {
 
     println!("Retrieving indicators for {} tickers", sel_tickers.len());
     start = std::time::Instant::now();
-    
+
     let res = jpamqs_download.save_indicators_as_csv(
         JPMaQSDownloadGetIndicatorArgs {
             tickers: sel_tickers.clone(),
             ..Default::default()
         },
-        5000,
         "./data/",
     );